Avoid copying folders that are not present in CI #34224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37961092 |
Merged
Base commit: d0b1d49 |
Base commit: e1d17c8 |
Summary: This Diff is a copy of this [PR](facebook#34228) that we have against 0.69-stable. This Diff makes sure we can build Hermes also in PR that are created against a stable branch ## Changelog [General] [Changed] - Make sure we can build Hermes from source when PR are opened agains -stable Differential Revision: D37961092 fbshipit-source-id: f9f9c9a71fa39303ddb775c10f9ad3d3ea2843f2
|
This pull request was exported from Phabricator. Differential Revision: D37961092 |
cipolleschi
force-pushed
the
export-D37961092
branch
from
1678698 to
5d7a490
Compare
|
This pull request was successfully merged by @cipolleschi in 361d939. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff is a copy of this PR that we have against 0.69-stable.
This Diff introduces some checks to prevent that we try to copy folders that are not present.
Changelog
Avoid copying the folders when they are not there.
[General] [Changed] - When preparing the Hermes workspace, we don't copy the folders that are not present.
Differential Revision: D37961092